Skip to content

Conversation

geckod22
Copy link
Contributor

@geckod22 geckod22 commented Aug 6, 2025

Proposed changes

This PR aims to solve a problem within iframes added by Divi builder code widget. In this case if the code added has line breaks, an html comment is added for each line break inside the iframe tag itseld, and this brake our parsing process and so the widgets itself.

before the fix, the page is like empty

imagen

with the fix the widgtes are showed

imagen

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Visual

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@geckod22 geckod22 requested a review from a team as a code owner August 6, 2025 13:19
Copy link
Contributor

github-actions bot commented Aug 6, 2025

Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Moving this to QA.

@arunshenoy99 arunshenoy99 removed the QA label Aug 28, 2025
@arunshenoy99 arunshenoy99 merged commit c780c76 into main Aug 28, 2025
15 of 17 checks passed
@arunshenoy99 arunshenoy99 deleted the FIX/PRESS7-524-lazy-load-with-divi branch August 28, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants